Testing for clearing of eager loaded non cacheable relations #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot cleared and as a result will provide stale data.
|
@Hornet-Wing Awesome! I will try to get to it this weekend. :) |
|
@Hornet-Wing Go ahead and give release 0.7.2 a try. The final implementation ended up being that any queries that have non-catchable eager-loaded relationships will not be cached in their entirety to avoid the cache of the relationship going stale. There really was no other way around that. |
|
Sorry it took me a little while to get this tested. Unfortunetly my main project is still 5.8 so I created a seperate project to test this in isolation. Unfortunetly it still doesnt quite work as expected. I'm planning on taking a closer look, maybe my tests were wrong. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test to demostrate the bug discussed in #292. I have tried to use existing test classes and models but I can adapt it to create bespoke ones. Let me know if this is OK.